Fix answer search URL chat loading#316
Merged
Merged
Conversation
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
BigSimmo
marked this pull request as ready for review
July 6, 2026 06:16
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Bugbot Autofix prepared a fix for the issue found in the latest run.
- ✅ Fixed: Indefinite answer loading skeleton
- Gated submittedAnswerSearchActive on canRunSearch so answer-mode URLs that cannot auto-run show the answer home instead of a perpetual loading skeleton.
You can send follow-ups to the cloud agent here.
Reviewed by Cursor Bugbot for commit 7828552. Configure here.
…rch-chat-d1ea Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
Gate submittedAnswerSearchActive on canRunSearch so auto-run URLs that cannot start a search show the answer home instead of a perpetual loading skeleton when the auto-run effect exits without calling ask.
Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>
BigSimmo
enabled auto-merge
July 6, 2026 07:41
15 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
run=1searches submit the URL query into the chat flow instead of rendering the answer home copy.origin/main, accepted the Bugbot Autofix guard for non-runnable answer searches, and formatted the final PR head.Walkthrough
answer_search_url_recheck_merge_ready.mp4
Answer search URL recheck loading state
Verification
npm run format:checknpm run test:e2e:chromium -- tests/ui-smoke.spec.ts -g "answer search URL opens chat without the answer home copy"npm run verify:cheapnpm run verify:uiwhen UI, routing, styling, browser behavior, reduced-motion, or forced-colors behavior changednpm run check:production-readiness:civerifyui-smokenpm run verify:releasebefore release or handoff confidence claims — not run; release gate is broader than this focused UI/routing fix.npm run eval:retrieval:quality— not applicable; no retrieval/ranking/scoring behavior changed.npm run eval:rag -- --limit 15+npm run eval:quality -- --rag-only— not applicable; no answer generation or synthesis prompt changes.npm run check:edge:functionslocally — command exits cleanly but skips because Deno v2 is not installed in this VM; GitHub CI installs Deno and passedverify.Clinical Governance Preflight
Not applicable; this change is limited to answer-mode URL submission and loading/home-state rendering.
Notes
mergeStateStatus: BLOCKED, likely due to repository merge policy/review requirements.To show artifacts inline, enable in settings.